bug fix: partials do not render on windows 7. #119
Conversation
Fix detailed here: #102
| @@ -19,7 +19,7 @@ module.exports = { | |||
| return false; | |||
| } | |||
|
|
|||
| var path_portions = template_path.split(Path.sep || "/"); | |||
| var path_portions = template_path.split("/"); | |||
There was a problem hiding this comment.
hmm..weird. What's returned in windows for Path.sep?
There was a problem hiding this comment.
so in template_handler.js isSection: function(template_path){}
the template_path variable contains paths formatted like /images\banner.
|
Check this PR from the past, which supposedly should fix path issues in Windows - #82. Can you figure out why removing |
|
Spent a bit more time looking at this issue today.
On windows For example page_renderer.js line 208 template_handler.js line 22 Removing the To fix the problem I guess Punch needs to consistently use the system defined path separator or reformat paths to use Anyway, I'm happy to keep working on this. Just not sure which way to go. |
|
The obvious solution is to use Path.sep everywhere, id go down that route if I were you |
I was attempting to follow the Punch setup tutorial but partials weren't rendering. I found the fix for the
problem here:
#102
My system is Windows 7 64bit.
Partials are now rendering after applying the fix. I have no idea what effects the changes will have when run on OSX and other operating systems. Sorry.